Configure Minio buckets, policies, and users #48
Conversation
|
@LakshithadeSilva @awalford16 does your work supersede this? |
|
Possibly. My work is mostly based on this, with some additional tweaks for setting anonymous access on the MinIO buckets. Once the STS approach is finalised, we can do the final work either on this PR or my branch. |
|
Can't review it as this is originally my PR, but LGTM @JimMadge |
|
@LakshithadeSilva is this ready to merge? |
|
@JimMadge Yes :) |
There was a problem hiding this comment.
Looks good. I like the model of running a job to configure MinIO using it's own CLI.
We might do similar things for cilium/longhorn.
@craddm can you also take a look at this. I think there may be some stuff leftover from experimenting, and the stack config might be overwriting changes on main.
| args=[ | ||
| "mc --insecure alias set argoartifacts http://minio.argo-artifacts.svc.cluster.local:80 $(MINIO_ROOT_USER) $(MINIO_ROOT_PASSWORD) &&" | ||
| "/tmp/scripts/setup.sh argoartifacts;", | ||
| ], |
There was a problem hiding this comment.
Is there a reason to pass some commands as an argument here and others in a script?
There was a problem hiding this comment.
@craddm possibly explain better, but 'mc' expects the alias to set first so the subsequent commands can refer to that alias. The script includes a bunch of mc commands, but alternatively we can have those here as well.
There was a problem hiding this comment.
So, does it not work if the mc alias set command is in the script?
There was a problem hiding this comment.
Modified this so all the commands are in the script, and the script now gets everything from the environment variables instead
No, I think @LakshithadeSilva's removed the remaining vestigial code |
3 participants
Closes #35